Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Feature/321 parameter history #557

Merged
merged 3 commits into from
Feb 13, 2021
Merged

Add Feature/321 parameter history #557

merged 3 commits into from
Feb 13, 2021

Conversation

jsnel
Copy link
Member

@jsnel jsnel commented Feb 12, 2021

Save the parameter history.

Testing

Tests are passing

Closing issues

closes #321

joernweissenborn and others added 2 commits February 12, 2021 19:48
@joernweissenborn @jsnel
added parameter history
1967085
@jsnel
Minor fix
da28c9c 
In case of crash history_index is -1
@jsnel jsnel added Priority: Medium Business as usual Status: In Progress Issues being worked on Type: Enhancement Feature requests labels Feb 12, 2021
@codecov
Copy link

codecov bot commented Feb 12, 2021 •
edited
Loading

Codecov Report

Merging #557 (8cc9879) into main (37438b0) will decrease coverage by 0.0%.
The diff coverage is 69.2%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #557     +/-   ##
=======================================
- Coverage   74.0%   73.9%   -0.1%     
=======================================
  Files         58      58             
  Lines       3378    3390     +12     
  Branches     639     640      +1     
=======================================
+ Hits        2500    2508      +8     
- Misses       736     739      +3     
- Partials     142     143      +1
Impacted Files Coverage Δ
glotaran/analysis/problem.py 94.6% <66.6%> (-0.5%) ⬇️
glotaran/analysis/optimize.py 81.5% <75.0%> (-0.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37438b0...8cc9879. Read the comment docs.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 13, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.16%.

Quality metrics Before After Change
Complexity 5.83 ⭐ 5.77 ⭐ -0.06 👍
Method Length 67.64 🙂 66.50 🙂 -1.14 👍
Working memory 11.00 😞 10.97 😞 -0.03 👍
Quality 62.74% 🙂 62.90% 🙂 0.16% 👍
Other metrics Before After Change
Lines 1182 1197 15
Changed files Quality Before Quality After Quality Change
glotaran/analysis/optimize.py 65.53% 🙂 63.45% 🙂 -2.08% 👎
glotaran/analysis/problem.py 62.61% 🙂 62.87% 🙂 0.26% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
glotaran/analysis/problem.py Problem._append_to_grouped_bag 8 ⭐ 274 ⛔ 27 ⛔ 31.33% 😞 Try splitting into smaller methods. Extract out complex expressions
glotaran/analysis/problem.py Problem.calculate_index_independent_ungrouped_residual 18 🙂 222 ⛔ 16 ⛔ 31.45% 😞 Try splitting into smaller methods. Extract out complex expressions
glotaran/analysis/problem.py Problem.calculate_index_dependent_ungrouped_residual 18 🙂 216 ⛔ 15 😞 32.96% 😞 Try splitting into smaller methods. Extract out complex expressions
glotaran/analysis/problem.py Problem._init_grouped_bag 7 ⭐ 200 😞 23 ⛔ 37.72% 😞 Try splitting into smaller methods. Extract out complex expressions
glotaran/analysis/problem.py Problem.calculate_index_dependent_grouped_matrices 7 ⭐ 277 ⛔ 13 😞 41.95% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jsnel jsnel merged commit 0172b31 into glotaran:main Feb 13, 2021
@jsnel jsnel deleted the feature/321_parameter_history branch February 13, 2021 15:25
s-weigand pushed a commit that referenced this pull request Feb 23, 2021
@jsnel @s-weigand
Add Feature/321 parameter history (#557)
08535b5 
* added parameter history
Closes #557 
Co-authored-by: Jörn Weißenborn <joern.weissenborn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joernweissenborn joernweissenborn Awaiting requested review from joernweissenborn joernweissenborn is a code owner

Assignees

@joernweissenborn joernweissenborn

Labels
Priority: Medium Business as usual Status: In Progress Issues being worked on Type: Enhancement Feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store the parameters of each optimization step
2 participants
@jsnel @joernweissenborn